Added helpfull message for DomainError #4249
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some functions throw DomainError for Real arguments because of type
stability and that the correct answer is complex. This patch add a ugly
hack, inspecting the bactrace, to give newcommers a helpefull hint.
See: #2144
I hate that this approach includes a list of functions (:log, :log2, :log10, :sqrt) that has to be updated and can not be extended by module writers, but from the discussion in #2144 it looks like something that might be accepted.