Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI (buildkite): ensure passing --output-sync when passing -j #42511

Merged
merged 2 commits into from
Oct 6, 2021

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Oct 5, 2021

To be at feature-parity with old buildbots (assuming the buildkite workers aren't ancient dinosaurs like some of the buildbots).

To be at feature-parity with old buildbots.
@vtjnash vtjnash requested a review from a team as a code owner October 5, 2021 19:51
@DilumAluthge DilumAluthge requested review from DilumAluthge and staticfloat and removed request for a team October 5, 2021 19:54
@DilumAluthge
Copy link
Member

Could you explain what this does?

@DilumAluthge DilumAluthge added backport 1.6 Change should be backported to release-1.6 backport 1.7 ci Continuous integration labels Oct 5, 2021
@DilumAluthge
Copy link
Member

(assuming the buildkite workers aren't ancient dinosaurs like some of the buildbots)

Just FYI, right now we are only running Buildkite agents on the newer AMDCI machines, but eventually, as we transition everything from Buildbot to Buildkite, we may end up running some Buildkite agents on some of the older machines as well.

@DilumAluthge
Copy link
Member

(assuming the buildkite workers aren't ancient dinosaurs like some of the buildbots)

Just FYI, right now we are only running Buildkite agents on the newer AMDCI machines, but eventually, as we transition everything from Buildbot to Buildkite, we may end up running some Buildkite agents on some of the older machines as well.

But if your concern (about old machines) is only about having too old a version of make, we can make sure that our build environments have a recent enough version of make.

@staticfloat
Copy link
Member

Yes, our grand plan is to not have ancient tool versions anymore, just ancient glibc versions.

@DilumAluthge
Copy link
Member

We need to update the coverage pipeline signature before merging this PR.

@DilumAluthge
Copy link
Member

I updated the signature.

@DilumAluthge DilumAluthge added the merge me PR is reviewed. Merge when all tests are passing label Oct 5, 2021
@vtjnash
Copy link
Member Author

vtjnash commented Oct 6, 2021

Looks like a I missed the ASAN builder, but I don't see where it called make -j

Separately, the linux32 trampolines seem to have an error in them (according to the linker) @staticfloat

@vtjnash vtjnash merged commit 82f60b4 into master Oct 6, 2021
@vtjnash vtjnash deleted the jn/buildkite-sync branch October 6, 2021 17:12
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Oct 6, 2021
KristofferC pushed a commit that referenced this pull request Oct 11, 2021
To be at feature-parity with old buildbots.

(cherry picked from commit 82f60b4)
KristofferC pushed a commit that referenced this pull request Oct 19, 2021
To be at feature-parity with old buildbots.

(cherry picked from commit 82f60b4)
KristofferC pushed a commit that referenced this pull request Nov 11, 2021
To be at feature-parity with old buildbots.

(cherry picked from commit 82f60b4)
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Nov 13, 2021
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
To be at feature-parity with old buildbots.

(cherry picked from commit 82f60b4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants