-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix exp(NaN16) and add tests #42555
fix exp(NaN16) and add tests #42555
Conversation
The Also, I don't understand how the |
It could be moved, but it won't change performance so I won't to keep the flow closer to that of the other implementations (especially since the computation is still needed in the common case). The reason why this is safe is that we are taking |
7fcd12c
to
a4167b4
Compare
a4167b4
to
7d1e589
Compare
Rebased to hopefully get a better CI run |
7d1e589
to
5912ace
Compare
Rebased with fixed tests. Lets see if this will finally work. |
Ready to merge? |
Merging tomorrow if there aren't objections. |
* fix exp(NaN16) and add tests (cherry picked from commit c8cc1b5)
what do I need to do to backport this? |
Nothing, it has the label so it will get backported. In fact, it already is :) |
* fix exp(NaN16) and add tests
* fix exp(NaN16) and add tests
Fixes #42554