-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow watchers for the active project #42731
Conversation
I'll merge soon, barring further concerns. |
@timholy After this PR is merged, could you make a PR to Pkg.jl with the necessary changes? |
Done. The test will be noisy until #41625 is fixed. |
68cf319
to
4c9625d
Compare
I don't think those are due to this PR, but it's a lot of failures so let's just see if things have improved. |
@timholy Can you rebase on the latest master? |
4c9625d
to
669ad59
Compare
This allows packages (with Revise as the intended target) to register themselves to be notified when the active project changes. This will allow Revise to keep track of the appropriate source for non-default environments. For practical effect, Pkg (and perhaps packages like Pluto) will have to switch from setting `Base.ACTIVE_PROJECT[]` directly to calling `Base.set_active_project`. Co-authored by: Jameson Nash <jameson@juliacomputing.com>
669ad59
to
fe2991f
Compare
@timholy If I understand correctly, currently to use this feature, you provide a callback function Would it instead make sense for the user to pass a callback function So then, users don't need to make an extra call to |
With the possibility of |
This allows packages (with Revise as the intended target) to register themselves to be notified when the active project changes. This will allow Revise to keep track of the appropriate source for non-default environments. For practical effect, Pkg (and perhaps packages like Pluto) will have to switch from setting `Base.ACTIVE_PROJECT[]` directly to calling `Base.set_active_project`. Co-authored by: Jameson Nash <jameson@juliacomputing.com>
This allows packages (with Revise as the intended target) to register themselves to be notified when the active project changes. This will allow Revise to keep track of the appropriate source for non-default environments. For practical effect, Pkg (and perhaps packages like Pluto) will have to switch from setting `Base.ACTIVE_PROJECT[]` directly to calling `Base.set_active_project`. Co-authored by: Jameson Nash <jameson@juliacomputing.com>
This allows packages (with Revise as the intended target) to register
themselves to be notified when the active project changes.
This will allow Revise to keep track of the appropriate source for
non-default environments.
For practical effect, Pkg (and perhaps packages like Pluto) will have
to switch from setting
Base.ACTIVE_PROJECT[]
directly to callingBase.set_active_project
.