Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

choosetests: Pkg/pkg is no longer relevant #42890

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Conversation

DilumAluthge
Copy link
Member

Now that we have removed the test/testgroups file from the Pkg stdlib (JuliaLang/Pkg.jl#2809), we no longer need to talk about "Pkg/pkg", and we can instead just work with "Pkg".

@DilumAluthge DilumAluthge added ci Continuous integration backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Nov 1, 2021
@DilumAluthge DilumAluthge merged commit 12b2ec7 into master Nov 2, 2021
@DilumAluthge DilumAluthge deleted the dpa/Pkg/pkg branch November 2, 2021 05:32
@vtjnash
Copy link
Member

vtjnash commented Nov 5, 2021

Do we need to worry that this is always printing now in CI:

��� Warning: Not skipping tests: Pkg/pkg, Pkg
��� @ Main /buildworker/worker/tester_linux32/build/share/julia/test/choosetests.jl:200

@DilumAluthge
Copy link
Member Author

We can safely ignore that.

Once this PR and the associated PRs have been backported to 1.6 and 1.7, I'll make a change to the Buildbot config to get rid of the warning. But I can't do it until the backporting is complete, because Buildbot changes apply to all branches (unlike Buildkite, where we can have different configs for different release branches).

KristofferC pushed a commit that referenced this pull request Nov 7, 2021
KristofferC pushed a commit that referenced this pull request Nov 7, 2021
KristofferC pushed a commit that referenced this pull request Nov 11, 2021
KristofferC pushed a commit that referenced this pull request Nov 12, 2021
@KristofferC KristofferC removed backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Nov 13, 2021
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants