FileWatching: fix API problems with FDWatcher #42926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add remaining FDEvents, and modernize this struct * add `isopen` function * do not deliver events after the FDWatcher is closed * do not delete events that have not been delivered * support running of these tests with Revise.jl * some threading problems still exist (where marked)
StefanKarpinski
approved these changes
Nov 3, 2021
There was a problem hiding this comment.
My only comment is thanks for doing this, @vtjnash. Otherwise I'm not really qualified to review.
|
Any chance you could cherry-pick that fix into its own PR that we could merge quickly? I'm seeing most (if not all) CI jobs failing on master with |
DilumAluthge
pushed a commit
that referenced
this pull request
Nov 9, 2021
|
|
I get this error too when trying Pkg.precompile in 1.8.0-DEV.927: |
aviatesk
pushed a commit
that referenced
this pull request
Nov 9, 2021
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
* add remaining FDEvents, and modernize this struct * add `isopen` function * do not deliver events after the FDWatcher is closed * do not delete events that have not been delivered * support running of these tests with Revise.jl * note: some threading problems still exist (where marked)
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
* add remaining FDEvents, and modernize this struct * add `isopen` function * do not deliver events after the FDWatcher is closed * do not delete events that have not been delivered * support running of these tests with Revise.jl * note: some threading problems still exist (where marked)
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isopenfunction