Backport #42901 to 1.7 (without #42583) #42965
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Ian! Test fired off, will report back :). |
|
This commit seems to do the trick, but may or may not introduce new (nondeterministic) failures. Ian and I chatted elsewhere and are testing another approach before circling back if necessary. Thanks again Ian! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports #42901 to 1.7 to fix #42839 and #42835 without changes from #42583 that were causing problems with RelationalAI builds (confirmation of these problems actually being gone pending from @Sacha0 😄)
This frankenstein backport shouldn't actually be merged, just want to provide a version for now that fixes the regression without vararg problems. Isolation of problems caused by #42583 and a subsequent patch should allow us to backport both neatly.
CC: @Sacha0 @NHDaly @JeffBezanson