inference: eliminate more potential widenconst(::TypeofVararg) cases
#42971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much Shuhei! Will give this a whirl and report back :). |
|
yeah, that should be really helpful ! |
vtjnash
approved these changes
Nov 7, 2021
Follows #42583. The missing case within `const_prop_function_heuristic` was originally reported from RationalAI's test suite. I added the other two cases by some code review.
aviatesk
force-pushed
the
avi/morevararg
branch
from
f6b3826
to
3de6f70
Compare
DilumAluthge
removed
the
merge me
66 tasks
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
JuliaLang#42971) Follows JuliaLang#42583. The missing case within `const_prop_function_heuristic` was originally reported from RerationalAI's test suite. I added the other two cases by some code review.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
JuliaLang#42971) Follows JuliaLang#42583. The missing case within `const_prop_function_heuristic` was originally reported from RerationalAI's test suite. I added the other two cases by some code review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #42583.
The missing case within
const_prop_function_heuristicwas originallyreported from RerationalAI's test suite. I added the other two cases by
some code review.