Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAPI] Add alias for LLVMExtraAddCPUFeaturesPass #43391

Merged
merged 1 commit into from
Dec 10, 2021
Merged

[CAPI] Add alias for LLVMExtraAddCPUFeaturesPass #43391

merged 1 commit into from
Dec 10, 2021

Conversation

vchuravy
Copy link
Member

Missing from #43085

@vchuravy vchuravy requested a review from maleadt December 10, 2021 17:04
@vchuravy vchuravy mentioned this pull request Dec 10, 2021
Merged
@oscardssmith
Copy link
Member

What does this do?

@vchuravy
Copy link
Member Author

What does this do?

It allows other pipelines like Enzyme to invoke the Julia CPUFeatures llvm pass.

https://github.com/wsmoses/Enzyme.jl/runs/4486055807?check_suite_focus=true#step:6:143

JIT session error: Symbols not found: [ julia.cpu.have_fma.f64 ]
Simple tests: Error During Test at /home/runner/work/Enzyme.jl/Enzyme.jl/test/runtests.jl:47
  Test threw exception
  Expression: (autodiff(tanh, Active, Active(1.0)))[1] ≈ 0.4199743416140261
  LLVM error: Failed to materialize symbols: { (main, { diffejulia_tanh_11397mustwrapwrap }) }
  Stacktrace:

@vchuravy vchuravy merged commit 07e5bd3 into master Dec 10, 2021
@vchuravy vchuravy deleted the vc/export_cpufeat branch December 10, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maleadt maleadt Awaiting requested review from maleadt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vchuravy @oscardssmith