add typing to global bindings #43455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeonschaub
added a commit
that referenced
this pull request
Jan 5, 2022
This is an initial proposal for supporting typed globals based on #43455. The syntax for this is either `global x::T` or just doing `x::T = 1` in global scope. It is even supported to add these annotations to globals from inside functions. The type declaration will then be applied when the method is defined and inside the function body conversion to the specified type will happen automatically, similar to type annotations for local variables. This conversion will not be applied if the assignment is not done inside the same scope of the type annotation however. This could potentially be supported as well, but the problem is that this would mean any assignment to a global variable - typed or not - would need to go through a call to `convert` first, since lowering can't know if a given binding already has a type annotation. This probably wouldn't be a good thing for latency and sysimage size and would add an invalidation risk. It is allowed to refine a type annotation, but there will be a warning. Widening the type or changing it to any other type that is not a subtype of the previous one is an error, since that could cause cached compiled code to become invalid. replaces #43455 closes #964
|
closing in favor of #43671 |
simeonschaub
added a commit
that referenced
this pull request
Jan 8, 2022
This is an initial proposal for supporting typed globals based on #43455. The syntax for this is either `global x::T` or just doing `x::T = 1` in global scope. It is even supported to add these annotations to globals from inside functions. The type declaration will then be applied when the method is defined and inside the function body conversion to the specified type will happen automatically, similar to type annotations for local variables. This conversion will not be applied if the assignment is not done inside the same scope of the type annotation however. This could potentially be supported as well, but the problem is that this would mean any assignment to a global variable - typed or not - would need to go through a call to `convert` first, since lowering can't know if a given binding already has a type annotation. This probably wouldn't be a good thing for latency and sysimage size and would add an invalidation risk. It is allowed to refine a type annotation, but there will be a warning. Widening the type or changing it to any other type that is not a subtype of the previous one is an error, since that could cause cached compiled code to become invalid. replaces #43455 closes #964
JeffBezanson
pushed a commit
that referenced
this pull request
Feb 8, 2022
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
Feb 17, 2022
add type declarations to global bindings replaces JuliaLang#43455 closes JuliaLang#964 Co-authored-by: Miguel Raz Guzmán Macedo <miguelraz@gmail.com>
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
add type declarations to global bindings replaces JuliaLang#43455 closes JuliaLang#964 Co-authored-by: Miguel Raz Guzmán Macedo <miguelraz@gmail.com>
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
add type declarations to global bindings replaces JuliaLang#43455 closes JuliaLang#964 Co-authored-by: Miguel Raz Guzmán Macedo <miguelraz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking a first stab at #964.
Still missing the backedges to trigger recompilation.
cc @StefanKarpinski @JeffBezanson