Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Base.asyncmap docs typo #43571

Merged
merged 1 commit into from
Feb 12, 2022
Merged

Fix Base.asyncmap docs typo #43571

merged 1 commit into from
Feb 12, 2022

Conversation

Jasha10
Copy link
Contributor

@Jasha10 Jasha10 commented Dec 27, 2021

This PR changes the word less to greater in the asyncmap docs.

Prior to this PR, the docs look like this:

`ntasks` can also be specified as a zero-arg function. In this case, the
number of tasks to run in parallel is checked before processing every element and a new
task started if the value of `ntasks_func` is less than the current number
of tasks.

Looking at the asyncmap implementation, I believe that "greater" is correct here.

@ViralBShah ViralBShah added the docs This change adds or pertains to documentation label Feb 12, 2022
@ViralBShah
Copy link
Member

ViralBShah commented Feb 12, 2022

I think this PR is correct, and should be merged and backported.

@vtjnash vtjnash merged commit 4c101a1 into JuliaLang:master Feb 12, 2022
@vtjnash vtjnash added backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Feb 12, 2022
KristofferC pushed a commit that referenced this pull request Feb 15, 2022
(cherry picked from commit 4c101a1)
@KristofferC KristofferC mentioned this pull request Feb 15, 2022
40 tasks
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request Feb 17, 2022
KristofferC pushed a commit that referenced this pull request Feb 19, 2022
(cherry picked from commit 4c101a1)
@KristofferC KristofferC mentioned this pull request Feb 19, 2022
50 tasks
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label May 16, 2022
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
(cherry picked from commit 4c101a1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants