-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS: workaround a dyld/libunwind deadlock issue since 12.1 #43701
Conversation
Is there a minimal reproducer that I can send to Apple? |
You can potentially just note that the documentation for these functions in libunwind implies it doesn't acquire a lock, and that dyld is now violating that: http://www.nongnu.org/libunwind/man/unw_step(3).html#section_4 |
Alright, I opened a feedback with Apple, we'll see if it goes anywhere. |
I can confirm that the MWE from #43578 is fixed
but stress testing it here made it deadlock with
|
Good catch. That is a different (but closely related) bug. |
Unfortunately something's still deadlocking for me. This is stopped with 0% cpu.
|
I've tried, but I can't get this to deadlock! Thanks @vtjnash ! |
…sue, since 12.1 Later, we should probably switch to using mach_exc_server generated from `mig mach_exc.defs`.
I just hit a similar repeatable deadlock on ubuntu on master
Note that I added a debug print to that error throw
|
This requires a manual backport against |
Apple reintroduced the old bug that we previously worked around in
fad04d3 with a similar patch to this.
Fixes #43578