Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LinearAlgebra] Bump libblastrampoline to v4.0.0 #43877

Merged
merged 1 commit into from
Jan 21, 2022
Merged

[LinearAlgebra] Bump libblastrampoline to v4.0.0 #43877

merged 1 commit into from
Jan 21, 2022

Conversation

staticfloat
Copy link
Member

This version allows loading of dual-interface libraries, such as MKL
v2022+. It enables both providing a suffix hint when loading a library
(to force detection of ILP64 or LP64 symbols) as well as being able to
load the same library for multiple interfaces.

@staticfloat
[LinearAlgebra] Bump libblastrampoline to v4.0.0
d351444 
This version allows loading of dual-interface libraries, such as MKL
v2022+.  It enables both providing a suffix hint when loading a library
(to force detection of ILP64 or LP64 symbols) as well as being able to
load the same library for multiple interfaces.
@staticfloat staticfloat added the linear algebra Linear algebra label Jan 20, 2022
@staticfloat
Copy link
Member Author 

julia> using LinearAlgebra, MKL_jll
       BLAS.lbt_forward(libmkl_rt; clear=true, suffix_hint="64")
       BLAS.lbt_forward(libmkl_rt; suffix_hint="")
       BLAS.get_config()
LinearAlgebra.BLAS.LBTConfig
Libraries: 
├ [ILP64] libmkl_rt.so
└ [ LP64] libmkl_rt.so

Looks good to me! We've officially got the ability to get dual-interface working with the latest version of MKL_jll! Special shout-out to Viral who has been doggedly pushing this for a long time.

@ViralBShah
Copy link
Member

Thanks @staticfloat - all your magic!

@ViralBShah
Copy link
Member

I suppose MKL.jl needs updating after this, right?

@ViralBShah ViralBShah mentioned this pull request Jan 20, 2022
Closed
@ViralBShah ViralBShah merged commit 5f79cb3 into master Jan 21, 2022
@ViralBShah ViralBShah deleted the sf/lbt_v400 branch January 21, 2022 12:01
@giordano giordano mentioned this pull request Jan 21, 2022
Merged
@carstenbauer
Copy link
Member

On current Julia master, after using MKL I get BLAS.get_num_threads() == 0 irrespective of what the number of threads actually is (i.e. set via MKL_NUM_THREADS or even after BLAS.set_num_threads(whatever)). On 4e83cce (parent of this PR) things are still working. So this seems to have been introduced here.

  [856f044c] MKL_jll v2022.0.0+0
  [33e6dc65] MKL v0.4.4

LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@staticfloat @LilithHafner
[LinearAlgebra] Bump libblastrampoline to v4.0.0 (JuliaLang#43877)
edff044 
This version allows loading of dual-interface libraries, such as MKL
v2022+.  It enables both providing a suffix hint when loading a library
(to force detection of ILP64 or LP64 symbols) as well as being able to
load the same library for multiple interfaces.
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@staticfloat @LilithHafner
[LinearAlgebra] Bump libblastrampoline to v4.0.0 (JuliaLang#43877)
4b7b053 
This version allows loading of dual-interface libraries, such as MKL
v2022+.  It enables both providing a suffix hint when loading a library
(to force detection of ILP64 or LP64 symbols) as well as being able to
load the same library for multiple interfaces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViralBShah ViralBShah ViralBShah approved these changes

Assignees
No one assigned
Labels
linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@staticfloat @ViralBShah @carstenbauer