Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] Update PCRE2 URL #43884

Merged
merged 4 commits into from
Jan 24, 2022
Merged

[deps] Update PCRE2 URL #43884

merged 4 commits into from
Jan 24, 2022

Conversation

giordano
Copy link
Contributor

Similar to JuliaPackaging/Yggdrasil#4293. The old
release tarballs are gone, so we have to use GitHub-generated snapshots and also
to run ./autogen.sh before ./configure.

Should fix #43878 but I didn't test it locally, I mainly followed the changes I had to in Yggdrasil as well.

Similar to JuliaPackaging/Yggdrasil#4293.  The old
release tarballs are gone, so we have to use GitHub-generated snapshots and also
to run `./autogen.sh` before `./configure`.
@vchuravy vchuravy added backport 1.6 Change should be backported to release-1.6 backport 1.7 building Build system, or building Julia or its dependencies labels Jan 21, 2022
@vchuravy
Copy link
Member

Do we not need to update the checksums?

@giordano
Copy link
Contributor Author

Likely, the tarballs changed. Where are the checksums?

@vchuravy
Copy link
Member

vchuravy commented Jan 21, 2022

https://github.com/JuliaLang/julia/blob/master/deps/checksums/pcre

make -f contrib/refresh_checksums.mk pcre

I often git rm the prior checksums file

@vtjnash
Copy link
Member

vtjnash commented Jan 21, 2022

Autogen requires programs that we avoid having in our dependency list.

@DilumAluthge
Copy link
Member

Is there a place we can get tarballs that don't require us to run autogen? I agree with Jameson that it would be optimal if we didn't need to add any new build dependencies.

@DilumAluthge
Copy link
Member

Alternatively, we could download the tarballs, run autogen, tar up the results, and host the resultant tarballs ourselves. Then users don't need autogen.

@giordano
Copy link
Contributor Author

Valentin had already asked in spack the PCRE2 dev to reupload the release tarballs somewhere. We're waiting for a reply

@giordano
Copy link
Contributor Author

The original tarball for 10.36 is now available on GitHub (same checksums): https://github.com/PhilipHazel/pcre2/releases/tag/pcre2-10.36. I updated this PR to just change the URL

@DilumAluthge DilumAluthge merged commit 9769024 into JuliaLang:master Jan 24, 2022
@giordano giordano deleted the mg/pcre2 branch January 24, 2022 19:51
ararslan pushed a commit that referenced this pull request Feb 5, 2022
(cherry picked from commit 9769024)
ViralBShah pushed a commit that referenced this pull request Feb 6, 2022
(cherry picked from commit 9769024)

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
KristofferC pushed a commit that referenced this pull request Feb 19, 2022
(cherry picked from commit 9769024)
@KristofferC KristofferC mentioned this pull request Feb 19, 2022
50 tasks
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label May 16, 2022
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
(cherry picked from commit 9769024)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pcre2 download server is permanently offline
5 participants