inference: follow #40985, special case _typeof_captured_variable
#43965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -588,7 +588,7 @@ isdispatchtuple(@nospecialize(t)) = (@_pure_meta; isa(t, DataType) && (t.flags & | |||
|
|
|||
| iskindtype(@nospecialize t) = (t === DataType || t === UnionAll || t === Union || t === typeof(Bottom)) | |||
| isconcretedispatch(@nospecialize t) = isconcretetype(t) && !iskindtype(t) | |||
| using Core: has_free_typevars | |||
| import Core: has_free_typevars | |||
There was a problem hiding this comment.
Any particular reason for this change? has_free_typevars should not be overloadable anyways, right?
There was a problem hiding this comment.
ah, that's just because I'm almost always using import just because of #36529.
simeonschaub
pushed a commit
that referenced
this pull request
Dec 9, 2022
skip type capturing in Core.Compiler Use Base.C_NULL rename to `_typeof_captured_variable` Use `_typeof_captured_variable = Core.Typeof` fix case of captured types with free typevars make `has_free_typevars` a builtin and add inference support fix tests add some more tests some more inference fixes inference: follow #40985, special case `_typeof_captured_variable` (#43965) * Revert "make `has_free_typevars` a builtin" This reverts commit 3d0bffc. * inference: follow #40985, special case `_typeof_captured_variable` Update base/reflection.jl
simeonschaub
pushed a commit
that referenced
this pull request
Oct 25, 2023
skip type capturing in Core.Compiler Use Base.C_NULL rename to `_typeof_captured_variable` Use `_typeof_captured_variable = Core.Typeof` fix case of captured types with free typevars make `has_free_typevars` a builtin and add inference support fix tests add some more tests some more inference fixes inference: follow #40985, special case `_typeof_captured_variable` (#43965) * Revert "make `has_free_typevars` a builtin" This reverts commit 3d0bffc. * inference: follow #40985, special case `_typeof_captured_variable` Update base/reflection.jl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @simeonschaub