Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove throw InexactError from tryparsenext #44004

Merged
merged 3 commits into from
Feb 3, 2022
Merged

Remove throw InexactError from tryparsenext #44004

merged 3 commits into from
Feb 3, 2022

Conversation

bachdavi
Copy link
Contributor

@bachdavi bachdavi commented Feb 1, 2022 •
edited
Loading

Fixes: #44003

There exists a test that checks that InexactError is thrown. I've changed it to an ArgumentError coming from Dates.parse_components

@bachdavi bachdavi mentioned this pull request Feb 1, 2022
Closed
@bachdavi
Copy link
Contributor Author

bachdavi commented Feb 3, 2022

@quinnj Thank you for the quick review! Unfortunately, it seems that two builds are failing due to unrelated errors. In one case, it's caused by float precision and in the other by randomness and an external process.

I don't have permission to merge this PR. If you want, you can go ahead and merge it 🙂

@fredrikekre fredrikekre merged commit c10dac1 into JuliaLang:master Feb 3, 2022
@bachdavi bachdavi deleted the dba-tryparse-date-throws-inexact-error branch February 3, 2022 09:36
@fredrikekre fredrikekre added backport 1.6 Change should be backported to release-1.6 backport 1.7 dates Dates, times, and the Dates stdlib module labels Feb 3, 2022
KristofferC pushed a commit that referenced this pull request Feb 15, 2022
@KristofferC
Dates parsing: remove throw InexactError from tryparsenext, fixes #…
462b7b4 
…44003 (#44004)

(cherry picked from commit c10dac1)
@KristofferC KristofferC mentioned this pull request Feb 15, 2022
Merged
40 tasks
KristofferC pushed a commit that referenced this pull request Feb 19, 2022
@KristofferC
Dates parsing: remove throw InexactError from tryparsenext, fixes #…
7821e64 
…44003 (#44004)

(cherry picked from commit c10dac1)
@KristofferC KristofferC mentioned this pull request Feb 19, 2022
Merged
50 tasks
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@LilithHafner
Dates parsing: remove throw InexactError from tryparsenext, fixes J…
70812d8 
…uliaLang#44003 (JuliaLang#44004)
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@LilithHafner
Dates parsing: remove throw InexactError from tryparsenext, fixes J…
8e3eade 
…uliaLang#44003 (JuliaLang#44004)
@Wynand Wynand mentioned this pull request May 5, 2022
Merged
@iamed2
Copy link
Contributor

iamed2 commented May 5, 2022

IMO this ends up being harder to deal with since ArgumentError is so vague. We have to handle this in LibPQ due to precision differences between PostgreSQL and Julia times.

Maybe this deserves its own exception type.

@Wynand Wynand mentioned this pull request May 5, 2022
Open
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label May 16, 2022
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@staticfloat
Dates parsing: remove throw InexactError from tryparsenext, fixes #…
9b9b310 
…44003 (#44004)

(cherry picked from commit c10dac1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quinnj quinnj quinnj approved these changes

Assignees
No one assigned
Labels
dates Dates, times, and the Dates stdlib module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tryparse throws an InexactError in millisecond DateFormat
5 participants
@bachdavi @iamed2 @quinnj @KristofferC @fredrikekre