Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #43960, evaluation order of splat inside ref #44024

Merged
merged 1 commit into from
Feb 7, 2022
Merged

fix #43960, evaluation order of splat inside ref #44024

merged 1 commit into from
Feb 7, 2022

Conversation

JeffBezanson
Copy link
Member

fix #43960

@JeffBezanson JeffBezanson added compiler:lowering Syntax lowering (compiler front end, 2nd stage) bugfix This change fixes an existing bug labels Feb 2, 2022
simeonschaub
simeonschaub approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@simeonschaub simeonschaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@simeonschaub simeonschaub added backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Feb 2, 2022
@JeffBezanson
Copy link
Member Author

Attempt 2!

@simeonschaub simeonschaub merged commit 546a774 into master Feb 7, 2022
@simeonschaub simeonschaub deleted the jb/fix43960 branch February 7, 2022 18:49
KristofferC pushed a commit that referenced this pull request Feb 15, 2022
@JeffBezanson @KristofferC
fix #43960, evaluation order of splat inside ref (#44024)
4026d5d 
(cherry picked from commit 546a774)
@KristofferC KristofferC mentioned this pull request Feb 15, 2022
Merged
40 tasks
KristofferC pushed a commit that referenced this pull request Feb 19, 2022
@JeffBezanson @KristofferC
fix #43960, evaluation order of splat inside ref (#44024)
8a02c32 
(cherry picked from commit 546a774)
@KristofferC KristofferC mentioned this pull request Feb 19, 2022
Merged
50 tasks
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@JeffBezanson @LilithHafner
fix JuliaLang#43960, evaluation order of splat inside ref (JuliaLang#…
1fa54dd 
…44024)
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@JeffBezanson @LilithHafner
fix JuliaLang#43960, evaluation order of splat inside ref (JuliaLang#…
9587768 
…44024)
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label May 16, 2022
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@JeffBezanson @staticfloat
fix #43960, evaluation order of splat inside ref (#44024)
e7c1345 
(cherry picked from commit 546a774)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeonschaub simeonschaub simeonschaub approved these changes

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug compiler:lowering Syntax lowering (compiler front end, 2nd stage)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrong evaluation order for splatted args in ref expression
3 participants
@JeffBezanson @simeonschaub @KristofferC