Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal docs for staticdata.c #44129

Merged
merged 5 commits into from
Feb 13, 2022
Merged

Add internal docs for staticdata.c #44129

merged 5 commits into from
Feb 13, 2022

Conversation

timholy
Copy link
Member

@timholy timholy commented Feb 11, 2022

No description provided.

Copy link
Member

@jpsamaroo jpsamaroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

src/staticdata.c Outdated Show resolved Hide resolved
src/staticdata.c Outdated Show resolved Hide resolved
src/staticdata.c Outdated Show resolved Hide resolved
src/staticdata.c Outdated Show resolved Hide resolved
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

src/staticdata.c Outdated Show resolved Hide resolved
timholy and others added 2 commits February 13, 2022 02:09
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
@timholy timholy marked this pull request as draft February 13, 2022 12:00
@timholy timholy changed the title Add internal docs for staticdata.c (NFC) Add internal docs for staticdata.c Feb 13, 2022
@timholy timholy marked this pull request as ready for review February 13, 2022 17:45
@timholy
Copy link
Member Author

timholy commented Feb 13, 2022

This is now a fairly comprehensive tour of staticdata.c; it might benefit from re-review, but hopefully I haven't said anything truly wrong.

It also has one small functional change, fixing a function return type I messed up in #43881, that I happened to notice while reading this (I must have glossed over the compiler warning).

@vtjnash vtjnash merged commit 2d6a84e into master Feb 13, 2022
@vtjnash vtjnash deleted the teh/staticdata_docs branch February 13, 2022 20:53
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request Feb 17, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants