Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dot(::Adjoint, ::Adjoint) for numbers that don't commute under multiplication #44219

Merged
merged 5 commits into from
Feb 19, 2022
Merged

Fix dot(::Adjoint, ::Adjoint) for numbers that don't commute under multiplication #44219

merged 5 commits into from
Feb 19, 2022

Conversation

sethaxen
Copy link
Contributor

@sethaxen @fredrikekre
Update stdlib/LinearAlgebra/src/generic.jl
bf27d31 
Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
@sethaxen
Copy link
Contributor Author

Should this be backported to 1.6? It would be annoying to have to work around this bug until the next LTS.

@fredrikekre fredrikekre added backport 1.6 Change should be backported to release-1.6 backport 1.7 backport 1.8 Change should be backported to release-1.8 linear algebra Linear algebra labels Feb 17, 2022
This was referenced Feb 18, 2022
Merged
Merged
@KristofferC KristofferC merged commit 928f63c into JuliaLang:master Feb 19, 2022
KristofferC pushed a commit that referenced this pull request Feb 23, 2022
@sethaxen @KristofferC
Fix dot(::Adjoint, ::Adjoint) for numbers that don't commute under mu…
7cb54f2 
…ltiplication (#44219)

Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
(cherry picked from commit 928f63c)
@KristofferC KristofferC mentioned this pull request Feb 23, 2022
Merged
40 tasks
KristofferC pushed a commit that referenced this pull request Feb 23, 2022
@sethaxen
Fix dot(::Adjoint, ::Adjoint) for numbers that don't commute under mu…
24fc8e2 
…ltiplication (#44219)

Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
(cherry picked from commit 928f63c)
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Feb 24, 2022
staticfloat pushed a commit to JuliaCI/julia-buildkite-testing that referenced this pull request Mar 2, 2022
@sethaxen @fredrikekre @staticfloat
Fix dot(::Adjoint, ::Adjoint) for numbers that don't commute under mu…
c523609 
…ltiplication (JuliaLang#44219)

Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@sethaxen @fredrikekre @LilithHafner
Fix dot(::Adjoint, ::Adjoint) for numbers that don't commute under mu…
f431736 
…ltiplication (JuliaLang#44219)

Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
@KristofferC
Copy link
Member

Does this really have to go into 1.6. The dot(x::Adjoint, y::Adjoint) was added in #39004 which is not in 1.6. Am I missing something?

@dkarrasch
Copy link
Member

Should this be backported to 1.6? It would be annoying to have to work around this bug until the next LTS.

We don't need to backport to v1.6. IIRC, then #39004 was just for performance, so there is no (should not be) bug in the LTS regarding dot of Adjoints.

@dkarrasch dkarrasch removed the backport 1.6 Change should be backported to release-1.6 label Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkarrasch dkarrasch dkarrasch left review comments

@oscardssmith oscardssmith oscardssmith left review comments

@fredrikekre fredrikekre fredrikekre left review comments

@andreasnoack andreasnoack andreasnoack approved these changes

Assignees
No one assigned
Labels
linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dot(::Adjoint, ::Adjoint) incorrect for numbers that are not multiplicatively commutative
6 participants
@sethaxen @KristofferC @dkarrasch @andreasnoack @fredrikekre @oscardssmith