Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings about unused static function #44255

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

fingolfin
Copy link
Member

There are a TON of warnings when compiling Julia right now,
get rid of some of them

@giordano giordano added the building Build system, or building Julia or its dependencies label Feb 19, 2022
@ViralBShah
Copy link
Member

It would be better to fix the warnings than to silence them - because if silenced, they'll never be seen and fixed.

@fingolfin
Copy link
Member Author

Well, one part of this PR fixes the root cause of some warnings. The other fixes warnings about the use of a C feature that is officially not supported in current C++, but in practice GCC and clang support. So unless someone rewrites the code in question (e.g. @Keno, who wrote that code in the first place?), I see no alternative to turning off this warning. The warning is of very limited use anyway, as both gcc and clang support the feature and it won't go away, there are so many other things that really limit the current code base to clang and gcc

@giordano
Copy link
Contributor

Looks like the warning is emitted only by clang? With GCC now you get

cc1: warning: unrecognized command line option '-Wno-nested-anon-types'

which ironically is a new warning.

@vtjnash
Copy link
Member

vtjnash commented Feb 22, 2022

The nested-anon-types are also being used to violate TBAA, so we should probably just remove it.

@fingolfin fingolfin changed the title Silence some C compiler warnings Fix warnings about unused static function Feb 23, 2022
@fingolfin
Copy link
Member Author

I've removed the Makefile change and changed the title correspondingly to "Fix warnings about unused static function"

@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Feb 23, 2022
@simeonschaub simeonschaub merged commit 262c6f1 into JuliaLang:master Feb 23, 2022
@simeonschaub simeonschaub removed the merge me PR is reviewed. Merge when all tests are passing label Feb 23, 2022
staticfloat pushed a commit to JuliaCI/julia-buildkite-testing that referenced this pull request Mar 2, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@fingolfin fingolfin deleted the mh/silence-warnings branch March 31, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants