Guard GCC-specific macros with _COMPILER_GCC_
#44353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
force-pushed
the
mg/clang-linux
branch
from
7988852 to
11ee8df
Compare
vtjnash
reviewed
Feb 26, 2022
giordano
force-pushed
the
mg/clang-linux
branch
2 times, most recently
from
8f98c16 to
bfb01f4
Compare
giordano
changed the title
!defined(__clang__)_COMPILER_GCC_
By default Clang on Linux defines the macro `__GNUC__`, so to guard GCC-specific code paths it isn't sufficient to check `#ifdef __GNUC__`. Co-authored-by: Jameson Nash <vtjnash@users.noreply.github.com>
giordano
force-pushed
the
mg/clang-linux
branch
from
bfb01f4 to
98444bc
Compare
staticfloat
pushed a commit
to JuliaCI/julia-buildkite-testing
that referenced
this pull request
Mar 2, 2022
By default Clang on Linux defines the macro `__GNUC__`, so to guard GCC-specific code paths it isn't sufficient to check `#ifdef __GNUC__`.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
By default Clang on Linux defines the macro `__GNUC__`, so to guard GCC-specific code paths it isn't sufficient to check `#ifdef __GNUC__`.
KristofferC
pushed a commit
that referenced
this pull request
May 23, 2022
By default Clang on Linux defines the macro `__GNUC__`, so to guard GCC-specific code paths it isn't sufficient to check `#ifdef __GNUC__`. (cherry picked from commit bcc0f70)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default Clang on Linux defines the macro
__GNUC__, so to guard GCC-specificcode paths it isn't sufficient to check
#ifdef __GNUC__.If @Keno confirms this was the intended check, this would fix #44352. In the meantime I can confirm I can successfully build this branch with Clang (
CC=clang CXX=clang++) on Linux.