-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CompilerSupportLibraries_jll] Update to v0.5.2 #44487
Conversation
99ebcb4
to
35a4196
Compare
@@ -1,4 +1,4 @@ | |||
# -*- mode: makefile-gmake -*- | |||
# -*- mode: makefile -*- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to Emacs, now we have proper syntax highlighting in GitHub for this file 🙂
The main difference since previous version should be the libraries for aarch64-apple-darwin, which are based on a more recent version of the GCC fork for this platform. There are a couple of notable ABI changes here: * `libgcc_s` is now called `libgcc_s.1.1.dylib` instead of `libgcc_s.2.dylib` * there is now `libquadmath.0.dylib` for this platform, which was missing before.
ifeq ($(APPLE_ARCH),arm64) | ||
$(eval $(call symlink_system_library,CSL,libgcc_s,1.1)) | ||
else | ||
$(eval $(call symlink_system_library,CSL,libgcc_s,1)) | ||
endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fxcoudert can you please try this out now? Ref: #44435 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm that this change works for me.
The main difference since previous version should be the libraries for aarch64-apple-darwin, which are based on a more recent version of the GCC fork for this platform. There are a couple of notable ABI changes here: * `libgcc_s` is now called `libgcc_s.1.1.dylib` instead of `libgcc_s.2.dylib` * there is now `libquadmath.0.dylib` for this platform, which was missing before. (cherry picked from commit cb2fa5d)
The main difference since previous version should be the libraries for aarch64-apple-darwin, which are based on a more recent version of the GCC fork for this platform. There are a couple of notable ABI changes here: * `libgcc_s` is now called `libgcc_s.1.1.dylib` instead of `libgcc_s.2.dylib` * there is now `libquadmath.0.dylib` for this platform, which was missing before. (cherry picked from commit cb2fa5d)
The main difference since previous version should be the libraries for
aarch64-apple-darwin, which are based on a more recent version of the GCC fork
for this platform. There are a couple of notable ABI changes here:
libgcc_s
is now calledlibgcc_s.1.1.dylib
instead oflibgcc_s.2.dylib
(ref: System library build of Julia master fails on ARM macOS #44435)libquadmath.0.dylib
for this platform, which was missingbefore.
Usual memo to self, update the library:
stdlib/CompilerSupportLibraries_jll/Project.toml
,make -f contrib/refresh_checksums.mk -j csl
and remove the old checksums from the updated file deps/checksums/compilersupportlibraries