Mark as inline functions implemented in src/serialize.h
#44739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hehe, I was just about to make a similar PR :-). Glad I looked here first. Hopefully this can be merged soon, it seems innocent enough. The buildkite failure stems from an unrelated test (apparently "128 == 16" does not hold... 😂) |
fingolfin
approved these changes
Mar 31, 2022
giordano
force-pushed
the
mg/inline-serialize
branch
from
dc48c2b to
6a38f3c
Compare
|
With #44350 now merged, in a local rebase of this PR onto latest |
vtjnash
added
merge me
|
triage is busy, they should not be getting asked to review this type of PR |
DilumAluthge
removed
the
merge me
|
analyzegc needs to be fixed. |
Also, remove duplicate definitions from `src/staticdata.c` and include `serialize.h` in there.
This breaks analyzegc
giordano
force-pushed
the
mg/inline-serialize
branch
from
6a38f3c to
9ed8033
Compare
|
I reverted the conversion of macros to functions, now analyzegc is happy again |
KristofferC
pushed a commit
that referenced
this pull request
Oct 28, 2022
* Mark as `inline` functions implemented in `src/serialize.h` Also, remove duplicate definitions from `src/staticdata.c` and include `serialize.h` in there. (cherry picked from commit 081ae64)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #44634 (comment) it was suggested that these functions were implemented in the header to allow inlining, but they weren't annotated with
inline, thus causing a warning when the functions were unused.Also, remove duplicate definitions from
src/staticdata.cand includeserialize.hin there.