Updated 32 bit heuristics #44805
Merged
Updated 32 bit heuristics #44805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps with JuliaLang#40644 and other programs which suffer from non-productive full collections.
…uent full collections.
We try really hard to stay under 2gb but if the live data exceeds that size we keep the interval small and perform full gcs until we get back under 2gb.
chflood
changed the title
oscardssmith
approved these changes
Mar 31, 2022
|
Is this going to fix our linux32 and win32 build failures? Looks promising - at least win32 is passing. |
added 2 commits
April 6, 2022 14:07
oscardssmith
added
system:32-bit
|
What happened to the fixed debug print statements? |
|
I believe they got fixed in a separate PR. |
|
I don't think so. They are mentioned in the title of this pull request, they were introduced in b82679a. Af far as I can tell, currently in |
|
I wanted to separate the two issues because I thought you guys were fixing
this.
I think the better way to fix it is to use PRI macros and I can put
together a PR.
Christine
Christine
…On Thu, Apr 7, 2022 at 4:54 PM Mosè Giordano ***@***.***> wrote:
I don't think so. They are mentioned in the title of this pull request,
they were introduced in b82679a
<b82679a>.
Af far as I can tell, currently in master these lines were last touched
by me:
https://github.com/JuliaLang/julia/blame/f536b81aea93af0ed03543198560cf436e7def51/src/gc-debug.c#L985
—
Reply to this email directly, view it on GitHub
<#44805 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE3CLBBCOYQIAE5YJIQZ7LLVD5DPNANCNFSM5SD4TRFQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Having the fix in a different pull request is totally fine (and probably even better, as it's slightly orthogonal to this pull request), but that's still mentioned in the title of this PR and I don't see any other PR with it. Hence why I'm wondering what happened to it 🙂 |
|
OK, I just submitted the fix for the print errors in a separate PR. |
giordano
changed the title
|
Ready to merge? |
|
I think so.
…On Mon, Apr 11, 2022 at 7:21 PM Oscar Smith ***@***.***> wrote:
Ready to merge?
—
Reply to this email directly, view it on GitHub
<#44805 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE3CLBBO6ZOGPCUVJ4T3ME3VESXZFANCNFSM5SD4TRFQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
DilumAluthge
added
merge me
DilumAluthge
removed
the
merge me
|
Thanks @chflood! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We try really hard to stay under 2gb but if the live data exceeds that
size we keep the interval small and perform full gcs until we get back
under 2gb.