Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implicit binding import for aliased bindings #44827

Merged
merged 1 commit into from
Apr 2, 2022

Conversation

Pangoraw
Copy link
Contributor

@Pangoraw Pangoraw commented Apr 1, 2022

Fixes #44754

The import has to be done with b->name as the name inside b->owner and use var only as the asname when importing.

`b->name` is used to lookup in `b->owner`, not `var`.
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Apr 1, 2022
@giordano giordano merged commit dbe41d4 into JuliaLang:master Apr 2, 2022
@giordano giordano removed the merge me PR is reviewed. Merge when all tests are passing label Apr 2, 2022
@Pangoraw Pangoraw deleted the using_aliased_name branch April 2, 2022 12:30
@JeffBezanson JeffBezanson added bugfix This change fixes an existing bug modules labels Apr 4, 2022
@ararslan ararslan added backport 1.6 Change should be backported to release-1.6 backport 1.8 Change should be backported to release-1.8 labels Nov 11, 2022
KristofferC pushed a commit that referenced this pull request Dec 14, 2022
`b->name` is used to lookup in `b->owner`, not `var`.

(cherry picked from commit dbe41d4)
@KristofferC KristofferC mentioned this pull request Dec 14, 2022
26 tasks
KristofferC pushed a commit that referenced this pull request Dec 14, 2022
`b->name` is used to lookup in `b->owner`, not `var`.

(cherry picked from commit dbe41d4)
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Dec 16, 2022
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
`b->name` is used to lookup in `b->owner`, not `var`.

(cherry picked from commit dbe41d4)
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
`b->name` is used to lookup in `b->owner`, not `var`.

(cherry picked from commit dbe41d4)
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
`b->name` is used to lookup in `b->owner`, not `var`.

(cherry picked from commit dbe41d4)
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
`b->name` is used to lookup in `b->owner`, not `var`.

(cherry picked from commit dbe41d4)
KristofferC pushed a commit that referenced this pull request Oct 10, 2023
`b->name` is used to lookup in `b->owner`, not `var`.

(cherry picked from commit dbe41d4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.6 Change should be backported to release-1.6 bugfix This change fixes an existing bug modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spurious warning when using exported names that are renamed with as
6 participants