-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unfold()
is an iterable based on a transition function
#44873
Open
nlw0
wants to merge
33
commits into
JuliaLang:master
Choose a base branch
from
nlw0:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+136
−1
Open
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
ff456dd
IterableClosure is an iterator based on a closure
nlw0 f7e6dcd
Greatly improved implementation mostly by @Seelengrab
nlw0 f82e527
Update iterators.jl
nlw0 a097683
Update iterators.jl
nlw0 81bf243
one-liner iterate
nlw0 ba1c5fa
Update base/iterators.jl
nlw0 a1dc72e
Update base/iterators.jl
nlw0 6c68372
Update base/iterators.jl
nlw0 751dd4e
Update base/iterators.jl
nlw0 88dfb1e
rename plus slight eltype correction
nlw0 75c729b
docstring
nlw0 6df1cbe
some Unfold tests
nlw0 6ddf28e
Unfold range test
nlw0 9fcb440
doc, news
nlw0 24e9d85
Unfold tree test
nlw0 bdc531b
Update test/iterators.jl
nlw0 96a2fdf
replaced a couple of tests
nlw0 bf03b47
type specifications seem to have caused a problem
nlw0 0847d9f
removing initial state from struct, separate unfold function based on…
nlw0 5b782d5
reference to previous PR on NEWS.md
nlw0 62cfe4f
docs fix and removing mysteryous lingering definition
nlw0 1ba74ea
exporting and slight docstring changes
nlw0 e29ff52
default eltype thing didn't work, making it two separate methods
nlw0 560c643
added compat string
nlw0 429a235
copying extended help from #43203
nlw0 492bf41
Merge branch 'master' into patch-1
nlw0 55fbc4f
Update base/iterators.jl
nlw0 37f4736
Update base/iterators.jl
nlw0 00bd697
minor
a7fbd09
Update test/iterators.jl
nlw0 ef4743a
missing end
0d1518c
Merge branch 'master' into patch-1
nlw0 b20b110
unfold eltype as a keyword argument
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is SizeUnknown() not the default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really familiar with how this works, but there are many similar definitions in this file, including for
Filter
andTakeWhile
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the default is
HasLength()
. This is ok.