-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect shared JIT variables from being modified unsafely #44914
Conversation
23c6838
to
b1b92fb
Compare
ade0463
to
0672563
Compare
0672563
to
ee47379
Compare
seems related?
|
The pthread documentation suggests that this is caused by attempting to operate on an uninitialized mutex, which could probably happen during setup or teardown (I think the mutex should be initialized once the constructor of EE finishes). Is adding an initialized boolean flag that we assert on every operation too expensive to detect such errors? |
I don't think you can solve race conditions by adding more data races. Oft times, I simply try to leak the memory to avoid cleanup problems, if that is the issue here. |
9bdafdb
to
c9294ea
Compare
c936340
to
7132816
Compare
@vtjnash Looks like the macos mutex errors are fixed, does this look good to merge as-is? |
Depends on #44912Depends on #45016 to fix the macos segfaults