Add docstring for fallback fetch(::Any) method
#45008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cannot just include `Base.fetch` in the `@docs` block as some methods should keep being documented in the Distributed stdlib rather than in Base.
nalimilan
added
docs
|
Anybody willing to review? |
oscardssmith
approved these changes
May 11, 2022
|
I wonder why this exists at all? Is there some good use case? |
|
TBH I think it was a mistake to add this. But now that it exists we can't remove it, so I figured we'd better document it (I was surprised when I realized this worked). Maybe we can note somewhere that it should be removed in 2.0. |
|
I've filed #45425 so that we don't forget to consider its removal for 2.0. |
pchintalapudi
pushed a commit
that referenced
this pull request
May 25, 2022
We cannot just include `Base.fetch` in the `@docs` block as some methods should keep being documented in the Distributed stdlib rather than in Base.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot just include
Base.fetchin the@docsblock as some methods should keep being documented in the Distributed stdlib rather than in Base.The method was imported from stdlib by #30961.