rewrite the C/Fortran calling manual to use @ccall as the "first class" way of calling
#45206
Conversation
KristofferC
force-pushed
the
kc/ccall_to_@ccall
branch
from
b5bcf61 to
57db618
Compare
| end | ||
| ``` | ||
|
|
||
| Here, the input `p` is declared to be of type `Ref{gsl_permutation}`, meaning that the memory |
There was a problem hiding this comment.
Removed this based on the discussion in #42480 (comment) (cc @Gnimuc) and that it isn't ideal to have a wrong example like this and then only later describe that it is wrong.
…ass" way of calling
KristofferC
force-pushed
the
kc/ccall_to_@ccall
branch
from
57db618 to
50cf8cf
Compare
| ``` | ||
|
|
||
| Here is a slightly more complex example that discovers the local machine's hostname. | ||
| In this example, the networking library code is assumed to be in a shared library named "libc". |
There was a problem hiding this comment.
Removed this because it no longer works to specify "libc":
julia> gethostname()
ERROR: could not load library "libc"
/lib/x86_64-linux-gnu/libc.so: invalid ELF headerhttps://discourse.julialang.org/t/invalid-elf-header-0-7-0-beta-built-from-source/12054, #450
There was a problem hiding this comment.
As the comment here said, this was usually not correct ever, but we want to show the syntax for it here
There was a problem hiding this comment.
Okay, imo, let's show the syntax in a way that is correct then. Like for calling a locally compiled library.
| | `@ccall printf("%s = %d\n"::Cstring ; "foo"::Cstring, foo::Cint)::Cint` | `<unavailable>` | | ||
| | `@ccall printf("%s = %d\n"::Cstring ; "2 + 2"::Cstring, "5"::Cstring)::Cint` | `ccall(:printf, Cint, (Cstring, Cstring...), "%s = %s\n", "2 + 2", "5")` | | ||
| | `<unavailable>` | `ccall(:gethostname, stdcall, Int32, (Ptr{UInt8}, UInt32), hn, length(hn))` | | ||
|
|
There was a problem hiding this comment.
I think there is also:
| | `Base.@assume_effects :total @ccall sin(1::Cdouble,)::Cdouble` | `<unavailable>` | | |
There was a problem hiding this comment.
I don't think the effect system has been really documented at this point at right now it feels pretty internal so I would probably leave this out until it gets a more official status.
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
The macro is much more convenient so I think it makes sense to emphasize that.
Fixes #44038. fixes #34862