Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow reinterpreting a non-singleton array into a singleton type #45370

Merged
merged 1 commit into from
May 24, 2022
Merged

Disallow reinterpreting a non-singleton array into a singleton type #45370

merged 1 commit into from
May 24, 2022

Conversation

Liozou
Copy link
Member

@Liozou Liozou commented May 19, 2022

Fix the issue reported by @Seelengrab at #43500 (comment).
I agree with the argument and the solution proposed there, which is implemented here.

As mentioned in the comment, if this fix is accepted, it should be backported to 1.8 too.

@johnnychen94 johnnychen94 added arrays [a, r, r, a, y, s] bugfix This change fixes an existing bug backport 1.8 Change should be backported to release-1.8 labels May 19, 2022
@KristofferC KristofferC mentioned this pull request May 23, 2022
Merged
67 tasks
@Liozou
Copy link
Member Author

Liozou commented May 23, 2022

CI failures seem unrelated.
For context, what this PR does is restoring the error-throwing behavior pre-1.8 for the particular case of reinterpret(::SingletonType, ::NonSingletonArray), except that the error is a pretty ArgumentError explaining what's happening instead of a DivideError.

@KristofferC KristofferC merged commit fc52b3f into JuliaLang:master May 24, 2022
@Liozou Liozou deleted the disallowreinterpretsingletonfromnot branch May 24, 2022 16:41
KristofferC pushed a commit that referenced this pull request May 26, 2022
@Liozou @KristofferC
Disallow reinterpreting a non-singleton array into a singleton type (#…
5892697 
…45370)

(cherry picked from commit fc52b3f)
@KristofferC KristofferC mentioned this pull request May 26, 2022
Merged
KristofferC added a commit that referenced this pull request May 27, 2022
@KristofferC @Liozou
Disallow reinterpreting a non-singleton array into a singleton type (#…
9a8ddd0 
…45370) (#45467)

(cherry picked from commit fc52b3f)

Co-authored-by: Lionel Zoubritzky <Liozou@users.noreply.github.com>
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
arrays [a, r, r, a, y, s] bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Liozou @KristofferC @johnnychen94