Add nothrow modeling for global assignment #45421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add the same handling for the new |
|
Yes, but can be a separate PR. Do you want to take a crack? |
aviatesk
approved these changes
May 23, 2022
| tristate_merge!(frame, Effects(EFFECTS_TOTAL, | ||
| effect_free=TRISTATE_UNKNOWN, | ||
| nothrow=TRISTATE_UNKNOWN)) | ||
| abstract_eval_global_assignment(interp, frame, lhs, t) |
There was a problem hiding this comment.
abstract_eval_xxx usually get return type information back, which is already computed here, so maybe we want to name this as handle_global_assignment! (after handle_control_backedge!) or something?
There was a problem hiding this comment.
Sure, that seems reasonable.
Currently global assignment conservatively taints nothrow. We can do better by looking at whether the global exists, isconst, its type, etc. and determine whether there is any possibility that the assignment will throw and taint the effect accordingly.
Keno
force-pushed
the
kf/globassignnothrow
branch
from
15cbf8f to
cb0f486
Compare
pchintalapudi
removed
the
merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently global assignment conservatively taints nothrow.
We can do better by looking at whether the global exists,
isconst, its type, etc. and determine whether there is
any possibility that the assignment will throw and taint
the effect accordingly.
Split out from #45272