Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Bump the SuiteSparse stdlib from f63732c to 8e83ebc #45473

Conversation

DilumAluthgeBot
Copy link
Contributor

@DilumAluthgeBot DilumAluthgeBot commented May 26, 2022

Stdlib: SuiteSparse
URL: https://github.com/JuliaSparse/SuiteSparse.jl.git
Branch: master
Old commit: f63732c
New commit: 8e83ebc
Bump invoked by: @DilumAluthge
Powered by: BumpStdlibs.jl

$ git log --oneline f63732c..8e83ebc
8e83ebc Add docstrings to local docs, add SuiteSparse citations to docstrings (#64)
f31dc2e Merge pull request #63 from IanButterworth/ib/testset_org_tweak
b33eab5 move threaded testsets to main process

@DilumAluthge DilumAluthge added the stdlib Julia's standard library label May 26, 2022
@DilumAluthge DilumAluthge added the linear algebra Linear algebra label May 26, 2022
@DilumAluthgeBot DilumAluthgeBot force-pushed the BumpStdlibs/SuiteSparse-8e83ebc branch from 1902e36 to e62f75b Compare May 29, 2022 05:41
@DilumAluthge
Copy link
Member

@ViralBShah @KristofferC Any idea how to fix the build failures?

@ViralBShah
Copy link
Member

ViralBShah commented May 29, 2022

cc @Wimmerer We may want to fix this and get this as the last merge in - before we start the process of combining SuiteSparse into SparseArrays and then subsequent excision from base.

@rayegun
Copy link
Member

rayegun commented May 30, 2022

I'm not sure what

Error: duplicate docs found for 'SuiteSparse.UMFPACK.lu' in `@docs` block in src/stdlib/SuiteSparse.md:23-29

means. Does that indicate there are multiple doc strings? There shouldn't be, the only two significant ones in UMFPACK are lu and lu!, and there is only one for each.

The other one is related to footnotes I added. Let me look at why it's not building correctly.

@DilumAluthge
Copy link
Member

Yeah I'm not sure what's causing the docs failure. Maybe @fredrikekre can help?

@rayegun
Copy link
Member

rayegun commented May 30, 2022

Indeed building those docs locally for me works perfectly (except some failing doctests which I've fixed after the transfer to SparseArrays so I'll leave be). I have no erroring footnotes (but now I see that they don't appear in the built docs which is weird).

That being said, I am missing a lot of documentation from https://suitesparse.juliasparse.org/dev/ compared to local. I hope that's not another artifact of moving repositories, sometimes the GitHub Documenter config gets messed up.

@KristofferC
Copy link
Member

KristofferC commented Jun 1, 2022

Error: duplicate docs found for 'SuiteSparse.UMFPACK.lu' in @docs block in src/stdlib/SuiteSparse.md:23-29

These are defined in SuiteSparse docs: https://github.com/JuliaSparse/SuiteSparse.jl/blob/master/docs/src/index.md and also in the SparseArrays docs (I think) and you cannot have two references to the same documentation in one documentation build. So the SuiteSparse docs have to be updated to not refer to these docs (since the packages are merged, maybe it should just link to the SparseArrays.SuiteSparse docs).

@ViralBShah
Copy link
Member

Maybe skip this one and bump everything once again with the updated combined package?

@DilumAluthge
Copy link
Member

Maybe skip this one and bump everything once again with the updated combined package?

Probably the easiest approach.

@DilumAluthge DilumAluthge marked this pull request as draft June 1, 2022 13:45
@DilumAluthgeBot DilumAluthgeBot deleted the BumpStdlibs/SuiteSparse-8e83ebc branch June 18, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear algebra Linear algebra stdlib Julia's standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants