Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename Base.@assume_effects :total_may_throw setting to :foldable #45534

Merged
merged 1 commit into from
Jun 1, 2022
Merged

rename Base.@assume_effects :total_may_throw setting to :foldable #45534

merged 1 commit into from
Jun 1, 2022

Conversation

aviatesk
Copy link
Member

@aviatesk aviatesk commented Jun 1, 2022

xref: #45448

@aviatesk aviatesk requested a review from Keno June 1, 2022 02:37
@oscardssmith
Copy link
Member

what about const_foldable?

@aviatesk
Copy link
Member Author

aviatesk commented Jun 1, 2022

what about const_foldable?

I'd prefer the simpler name.

@Keno
Copy link
Member

Keno commented Jun 1, 2022

Also note that this is the 1.8 backport of the name, which was already adjusted on master.

@aviatesk aviatesk merged commit 4c65dce into backports-release-1.8 Jun 1, 2022
@aviatesk aviatesk deleted the avi/rename branch June 1, 2022 04:29
@thchr thchr mentioned this pull request Jun 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keno Keno Keno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aviatesk @oscardssmith @Keno