Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.8] AMD Zen 3 CPU support (Fixes #45657) #45667

Merged

Conversation

LebedevRI
Copy link
Contributor

@LebedevRI LebedevRI commented Jun 13, 2022

I've omitted invpcid feature since it's clearly omitted for other CPU's.

It's a bit sad that the very same code
is being repeated in every project :/

Fixes #45657

(cherry picked from commit 3f047f7)

@LebedevRI LebedevRI changed the title [DRAFT][release-1.8] AMD Zen 3 CPU support (Fixes #45657) [release-1.8] AMD Zen 3 CPU support (Fixes #45657) Jun 13, 2022
@LebedevRI LebedevRI marked this pull request as ready for review June 13, 2022 22:44
@LebedevRI
Copy link
Contributor Author

@vchuravy @yuyichao assuming #45663 is merged, this is a precise cherry-pick of the commit-to-be-merged.
I've verified that the results are same/equivalent to the ones on master w/ #45663.

I've omitted `invpcid` feature since it's clearly omitted for other CPU's.

Fixes JuliaLang#45657

(cherry picked from commit 3f047f7)
@LebedevRI LebedevRI changed the base branch from release-1.8 to backports-release-1.8 June 14, 2022 10:54
@LebedevRI
Copy link
Contributor Author

@KristofferC FYI

@KristofferC
Copy link
Member

FYI, there is typically no need to make explicit backport PRs since them having the label is enough for it to get picked up and backported.

@KristofferC KristofferC merged commit 8fd0b2a into JuliaLang:backports-release-1.8 Jun 14, 2022
@LebedevRI LebedevRI deleted the znver3-backport branch June 14, 2022 11:21
@LebedevRI
Copy link
Contributor Author

@KristofferC noted. As i have said, i don't know the workflow here.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants