Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errorshow: Show hint when + is attempted on AbstractStrings #45823

Merged
merged 3 commits into from
Aug 31, 2022
Merged

errorshow: Show hint when + is attempted on AbstractStrings #45823

merged 3 commits into from
Aug 31, 2022

Conversation

merryhime
Copy link
Contributor

Addresses a part of #7512.

@KristofferC
Copy link
Member

Nice idea! Could use a test.

@merryhime
Copy link
Contributor Author

Good idea - wrote a simple test.

@giordano giordano mentioned this pull request Jul 10, 2022
Merged
@KristofferC KristofferC added merge me PR is reviewed. Merge when all tests are passing error messages Better, more actionable error messages labels Aug 30, 2022
@KristofferC KristofferC merged commit 3c7d96f into JuliaLang:master Aug 31, 2022
@merryhime merryhime deleted the strcat branch August 31, 2022 19:50
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Sep 3, 2022
@vtjnash
Copy link
Member

vtjnash commented Sep 6, 2022

why is CI reporting this test fails:

      From worker 10:	┌ Error: Hint-handler string_concatenation_hint_handler for MethodError in Base caused an error
      From worker 10:	└ @ Base.Experimental experimental.jl:321
missing                                         (10) |    42.50 |   0.30 |  0.7 |     704.53 |  2004.57

These register_error_hint should probably be going into REPL or InteractiveUtils; they probably should not be going into Base.

@KristofferC
Copy link
Member

Open an issue maybe?

@vtjnash vtjnash mentioned this pull request Sep 6, 2022
Closed
vtjnash added a commit that referenced this pull request Mar 15, 2023
@vtjnash
fix problem with string_concatenation_hint_handler
f76c16a 
Quiets an error on CI when running missing tests.

Refs #45823
@vtjnash vtjnash mentioned this pull request Mar 15, 2023
Merged
vtjnash added a commit that referenced this pull request Mar 16, 2023
@vtjnash
fix problem with string_concatenation_hint_handler (#49016)
3919a89 
Quiets an error on CI when running missing tests.

Refs #45823
oscardssmith pushed a commit to oscardssmith/julia that referenced this pull request Mar 20, 2023
@vtjnash @oscardssmith
fix problem with string_concatenation_hint_handler (JuliaLang#49016)
8329a56 
Quiets an error on CI when running missing tests.

Refs JuliaLang#45823
KristofferC pushed a commit that referenced this pull request Mar 24, 2023
@vtjnash
fix problem with string_concatenation_hint_handler (#49016)
43c1ba2 
Quiets an error on CI when running missing tests.

Refs #45823

(cherry picked from commit 3919a89)
Xnartharax pushed a commit to Xnartharax/julia that referenced this pull request Apr 19, 2023
@vtjnash @Xnartharax
fix problem with string_concatenation_hint_handler (JuliaLang#49016)
e7b0749 
Quiets an error on CI when running missing tests.

Refs JuliaLang#45823
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikekre fredrikekre fredrikekre left review comments

Assignees
No one assigned
Labels
error messages Better, more actionable error messages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@merryhime @KristofferC @vtjnash @fredrikekre @DilumAluthge