fix rounding edge cases on cld, fld, and rem

[t-bltg]

• fix Strange cld behaviour #45875;
• make docstrings more consistent (spacing around operators and after commas).

cc @eschnett for removal of cld def introduced in #8111.

Two tests marked broken before are now passing at

julia/test/numbers.jl

Line 2554 in f4801ff

@test rem(T(4), floatmin(T) * 2, mode) == 0 broken=(T == BigFloat && mode in (RoundUp,RoundFromZero))

One test had its sign modified (0.0 -> -0.0): isequal(rem(nextfloat(typemin(T)), T(2), RoundUp), -0.0).

[LilithHafner]

Thanks!

[LilithHafner]

This feels like two separate PRs, one fixes cld and the other is whitespace.

[t-bltg]

This feels like two separate PRs, one fixes cld and the other is whitespace.

Thanks, I've rebased the PR so that one commit denotes the actual fix and the second one contains whitespace, style & docstring modifications: I don't think splitting this into two PRs is needed.

[LilithHafner]

Pending CI, this looks good to me. Do you think it is ready to merge?

[t-bltg]

Pending CI

I keep re-triggering CI, but unrelated spurious failures keep showing up :/.

Do you think it is ready to merge?

Yes.

[LilithHafner]

The CI failure seems unrelated to me.

Thanks for your contribution! It's nice to see # FIXME: The broken case erroneously returns -Inf get removed.