docs: print extra information when deploying #46030
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly to print out a little bit of information why deployment doesn't happen. Currently, if the deploy config sets
all_ok=false
, then the wholedeploydocs
call will be completely silent. Should help us debug the current Buildkite failure.It also makes the
deploydocs
call conditional ondeploy
argument being passed, which I think is good idea since we're relying less on various CI variables telling us that whether we should deploy or not than we used to. Basically, I believe right now, if you setDOCUMENTER_KEY
,deploydocs
might try to do something, even if you're just building docs locally.cc @staticfloat, @fredrikekre