Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Refactors QR and Cholesky factorization codes #4621

Closed
wants to merge 10 commits into from
Closed

WIP: Refactors QR and Cholesky factorization codes #4621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
66761e1
Refactors QR code
jiahao Oct 23, 2013
6348a3a
Deprecates cholpfact, cholpfact!
jiahao Oct 24, 2013
18d0ec9
Fix dimension finding to work for StridedMatOrVec
jiahao Oct 26, 2013
028542a
Refactors QR code
jiahao Oct 23, 2013
f30f4a7
Deprecates cholpfact, cholpfact!
jiahao Oct 24, 2013
34d54f5
Fix dimension finding to work for StridedMatOrVec
jiahao Oct 26, 2013
2a9e42d
WIP
ViralBShah Dec 29, 2013
f321c7d
Merge branch 'cjh/nopivot-default' of github.com:JuliaLang/julia into…
ViralBShah Dec 30, 2013
ce4ab4d
Merge branch 'master' into cjh/nopivot-default
ViralBShah Dec 30, 2013
5fed276
Add chkfullrank. Fix inv(Cholesky). Define promotion rules for Q mult…
andreasnoack Dec 30, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions base/deprecated.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,14 @@ export PipeString
# copy!(dest::AbstractArray, doffs::Integer, src::Integer)
# in abstractarray.jl
@deprecate copy!(dest::AbstractArray, src, doffs::Integer) copy!(dest, doffs, src)
@deprecate qrpfact!(A) qrfact!(A, true)
@deprecate qrpfact(A) qrfact(A, true)
@deprecate qrp(A, thin) qr(A, thin, true)
@deprecate qrp(A) qr(A, true)
@deprecate cholpfact!(A) cholfact!(A, :U, true)
@deprecate cholpfact!(A,tol) cholfact!(A, :U, true, tol)
@deprecate cholpfact!(A,uplo,tol) cholfact!(A, uplo, true, tol)
@deprecate cholpfact(A) cholfact(A, :U, true)

deprecated_ls() = run(`ls -l`)
deprecated_ls(args::Cmd) = run(`ls -l $args`)
Expand Down
1 change: 1 addition & 0 deletions base/linalg.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ export
svdvals!,
svdvals,
symmetrize!,
symmetrize_conj!,
trace,
transpose,
tril,
Expand Down
4 changes: 2 additions & 2 deletions base/linalg/dense.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ function factorize!{T}(A::Matrix{T})
end
return lufact!(A)
end
return qrpfact!(A)
return qrfact!(A, true)
end

factorize(A::AbstractMatrix) = factorize!(copy(A))
Expand All @@ -441,7 +441,7 @@ function (\){T<:BlasFloat}(A::StridedMatrix{T}, B::StridedVecOrMat{T})
istriu(A) && return \(Triangular(A, :U),B)
return \(lufact(A),B)
end
return qrpfact(A)\B
return qrfact(A, true)\B
end

## Moore-Penrose inverse
Expand Down
Loading