Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

leq for reals falls back to le and eq #46341

Merged
merged 1 commit into from
Aug 17, 2022
Merged

leq for reals falls back to le and eq #46341

merged 1 commit into from
Aug 17, 2022

Conversation

jishnub
Copy link
Contributor

@jishnub jishnub commented Aug 14, 2022

Fixes #46327.
After this,

julia> struct A <: Real end

julia> Base.:(<)(::A, ::A) = false

julia> Base.:(==)(::A, ::A) = false

julia> A() <= A()
false

@KristofferC KristofferC merged commit ef511c9 into JuliaLang:master Aug 17, 2022
@jishnub
Copy link
Contributor Author

jishnub commented Aug 17, 2022

@KristofferC can this be backported to 1.8, as this may be seen as a bugfix?

@KristofferC KristofferC added backport 1.8 Change should be backported to release-1.8 backport 1.6 Change should be backported to release-1.6 labels Aug 17, 2022
KristofferC pushed a commit that referenced this pull request Aug 17, 2022
@jishnub
leq for reals falls back to le and eq (#46341)
27890c7 
(cherry picked from commit ef511c9)
@KristofferC KristofferC mentioned this pull request Aug 17, 2022
Merged
35 tasks
@jishnub jishnub deleted the leqreal branch August 17, 2022 16:49
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Sep 7, 2022
@KristofferC KristofferC mentioned this pull request Dec 21, 2022
Open
78 tasks
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@jishnub
leq for reals falls back to le and eq (#46341)
5b4a20f 
(cherry picked from commit ef511c9)
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@jishnub
leq for reals falls back to le and eq (#46341)
8682e25 
(cherry picked from commit ef511c9)
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@jishnub
leq for reals falls back to le and eq (#46341)
d7644bd 
(cherry picked from commit ef511c9)
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@jishnub @staticfloat
leq for reals falls back to le and eq (#46341)
6e8bf8a 
(cherry picked from commit ef511c9)
KristofferC pushed a commit that referenced this pull request Oct 10, 2023
@jishnub @KristofferC
leq for reals falls back to le and eq (#46341)
63e30db 
(cherry picked from commit ef511c9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport 1.6 Change should be backported to release-1.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default leq method for Reals seems inconsistent with docstring
2 participants
@jishnub @KristofferC