Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support invoke backedges for const (fix #44320) #46715

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Conversation

timholy
Copy link
Member

@timholy timholy commented Sep 12, 2022

This is a left-over piece of #46010, triggered by const args.

I am not certain this is all of them, might there be other paths to add_backedge! that we're not passing down invoketypes to? The issue is that in the case of an invoke backedge, not only do we have to add the proper signature-"decorated" backedge, we have to be sure we don't add the undecorated variant. Otherwise the caller will be invalidated even though the decorated backedge remains valid.

Fixes #44320

This is a left-over piece of #46010, triggered by const args.
@giordano
Copy link
Contributor

giordano commented Sep 12, 2022

Note that writing "fix #issue" won't actually link the PR to the issue. The magic text should go into the commit message body and/or the description of the PR. GitHub doesn't even linkify "fix #issue" in the title of a PR, so doing that will make it harder to actually visit the mentioned issue.

@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Sep 12, 2022
@timholy timholy merged commit ad19f2f into master Sep 12, 2022
@timholy timholy deleted the teh/fix_44320 branch September 12, 2022 21:09
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invoked signatures spuriously invalidate in precompilation
4 participants