Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backports-release-1.8: Track correct Tar release branch #46733

Conversation

DilumAluthge
Copy link
Member

Note: the target branch (base branch) of this PR is the backports-release-1.8 branch.

…`JuliaIO/Tar.jl` repo (not the `master` branch of the `JuliaIO/Tar.jl` repo)
@DilumAluthge DilumAluthge added the release Release management and versioning. label Sep 13, 2022
@DilumAluthge
Copy link
Member Author

cc: @ranocha

@DilumAluthge DilumAluthge changed the title For Julia 1.8.x, Tar should track the release-1.10 branch of the JuliaIO/Tar.jl repo (not the master branch of the JuliaIO/Tar.jl repo) [backports-release-1.8] For Julia 1.8.x, Tar should track the release-1.10 branch of the JuliaIO/Tar.jl repo (not the master branch of the JuliaIO/Tar.jl repo) Sep 13, 2022
@DilumAluthge
Copy link
Member Author

DilumAluthge commented Sep 13, 2022

This should be low-risk to merge, since it doesn't actually modify the commit of Tar that is being used.

@DilumAluthge DilumAluthge added the merge me PR is reviewed. Merge when all tests are passing label Sep 13, 2022
@IanButterworth
Copy link
Member

IanButterworth commented Sep 13, 2022

Title of this PR seems a bit awkward?

Perhaps just
[backports-release-1.8] Track Tar release branch?

IMO the title just needs to be a hint, not a full explanation.

Also, all the quoted formatting looks nice on GitHub (actually the iOS app doesn't support it) but makes for messy git commit history.

image

Just my two cents

@KristofferC KristofferC changed the title [backports-release-1.8] For Julia 1.8.x, Tar should track the release-1.10 branch of the JuliaIO/Tar.jl repo (not the master branch of the JuliaIO/Tar.jl repo) backports-release-1.8: Track correct Tar release branch Sep 13, 2022
@KristofferC KristofferC merged commit 16a7aac into backports-release-1.8 Sep 13, 2022
@KristofferC KristofferC deleted the dpa/1.8-tar-should-track-release-branch-not-master-branch branch September 13, 2022 10:57
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Release management and versioning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants