Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[win] Disable MSYS2 path munging when calling is.exe #46867

Merged
merged 1 commit into from
Sep 26, 2022
Merged

[win] Disable MSYS2 path munging when calling is.exe #46867

merged 1 commit into from
Sep 26, 2022

Conversation

staticfloat
Copy link
Member

Tragically, I believe MSYS2 is messing with options such as /VERYSILENT turning them instead into C:\msys2\VERYSILENT or similar.

@staticfloat
[win] Disable MSYS2 path munging when calling is.exe
d3619b1 
Tragically, I believe MSYS2 is messing with options such as
`/VERYSILENT` turning them instead into `C:\msys2\VERYSILENT` or
similar.
@inkydragon
Copy link
Member

Then run the build:

git clone https://github.com/JuliaLang/julia.git julia-win32
cd julia-win32
echo override XC_HOST = i686-w64-mingw32 >> Make.user
make
make win-extras (Necessary before running make binary-dist)
make binary-dist then make exe to create the Windows installer.
move the julia-*.exe installer to the target machine

https://github.com/JuliaLang/julia/blob/master/doc/src/devdocs/build/windows.md#cross-compiling-from-unix-linuxmacwsl

So why not make

  • win-extras as a conditional dependency of binary-dist.
  • binary-dist as a dependency of exe.

inkydragon
inkydragon approved these changes Sep 24, 2022
View reviewed changes
Copy link
Member

@inkydragon inkydragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • build exe with mingw64

LGTM.

@staticfloat staticfloat merged commit d97f248 into master Sep 26, 2022
@staticfloat staticfloat deleted the sf/inno_msys2_path_munging branch September 26, 2022 18:23
inkydragon pushed a commit to inkydragon/julia that referenced this pull request Sep 30, 2022
@staticfloat @inkydragon
[win] Disable MSYS2 path munging when calling is.exe (JuliaLang#46867)
f22fe50 
Tragically, I believe MSYS2 is messing with options such as
`/VERYSILENT` turning them instead into `C:\msys2\VERYSILENT` or
similar.
inkydragon pushed a commit to inkydragon/julia that referenced this pull request Sep 30, 2022
@staticfloat @inkydragon
[win] Disable MSYS2 path munging when calling is.exe (JuliaLang#46867)
ce62633 
Tragically, I believe MSYS2 is messing with options such as
`/VERYSILENT` turning them instead into `C:\msys2\VERYSILENT` or
similar.
@inkydragon inkydragon mentioned this pull request Sep 30, 2022
Closed
inkydragon pushed a commit to inkydragon/julia that referenced this pull request Sep 30, 2022
@staticfloat @inkydragon
[win] Disable MSYS2 path munging when calling is.exe (JuliaLang#46867)
85b90c6 
Tragically, I believe MSYS2 is messing with options such as
`/VERYSILENT` turning them instead into `C:\msys2\VERYSILENT` or
similar.
@inkydragon inkydragon mentioned this pull request Sep 30, 2022
Merged
DilumAluthge pushed a commit to inkydragon/julia that referenced this pull request Oct 1, 2022
@staticfloat @DilumAluthge
[win] Disable MSYS2 path munging when calling is.exe (JuliaLang#46867)
5df2b35 
Tragically, I believe MSYS2 is messing with options such as
`/VERYSILENT` turning them instead into `C:\msys2\VERYSILENT` or
similar.
staticfloat added a commit that referenced this pull request Oct 8, 2022
@inkydragon @staticfloat
[win] Backport win MSYS2 build pr (#46988)
7c4ac37 
* Build/win: Build with MSYS2 (#46140)

* Makefile: MSYS2: close path conversion for `DEP_LIBS`

Automatic path conversion will replace `:` with `;`

* Makefile: MSYS2: use `cygpath` for path convert

ref: https://www.msys2.org/docs/filesystem-paths/#manual-unix-windows-path-conversion

* devdoc/win/msys2: add build steps

* devdoc/win/msys2: Add x86/x64 build notes

* devdoc/win/msys2: apply sugestions

Co-Authored-By: Elliot Saba <staticfloat@gmail.com>

* Instead of `CC_WITH_ENV`, scope environment variables to targets

* Fix whitespace

Co-authored-by: Elliot Saba <staticfloat@gmail.com>

* Disable MSYS2's path munging for `stringreplace` (#46803)

This was causing our rewriting of the loader's RPATH emulation to fail
after running `make install`, as MSYS2 was rewriting our list that looks
like:

```
../bin/libgcc_s_seh-1.dll:../bin/libopenlibm.dll:@../bin/libjulia-internal.dll:@../bin/libjulia-codegen.dll:
```

Into one that looked like:
```
..\bin\libgcc_s_seh-1.dll;..\bin\libopenlibm.dll;@..\bin\libjulia-internal.dll;@..\bin\libjulia-codegen.dll;
```

By exporting `MSYS2_ARG_CONV_EXCL='*'` for all `stringreplace`
invocations, we dodge this issue, as documented by MSYS2 [0].

[0] https://www.msys2.org/wiki/Porting/#filesystem-namespaces

* [win] Disable MSYS2 path munging when calling `is.exe` (#46867)

Tragically, I believe MSYS2 is messing with options such as
`/VERYSILENT` turning them instead into `C:\msys2\VERYSILENT` or
similar.

Co-authored-by: Elliot Saba <staticfloat@gmail.com>
KristofferC pushed a commit that referenced this pull request Oct 28, 2022
@inkydragon @staticfloat @KristofferC
[win] Backport win MSYS2 build pr (#46988)
ddbb5bc 
* Build/win: Build with MSYS2 (#46140)

* Makefile: MSYS2: close path conversion for `DEP_LIBS`

Automatic path conversion will replace `:` with `;`

* Makefile: MSYS2: use `cygpath` for path convert

ref: https://www.msys2.org/docs/filesystem-paths/#manual-unix-windows-path-conversion

* devdoc/win/msys2: add build steps

* devdoc/win/msys2: Add x86/x64 build notes

* devdoc/win/msys2: apply sugestions

Co-Authored-By: Elliot Saba <staticfloat@gmail.com>

* Instead of `CC_WITH_ENV`, scope environment variables to targets

* Fix whitespace

Co-authored-by: Elliot Saba <staticfloat@gmail.com>

* Disable MSYS2's path munging for `stringreplace` (#46803)

This was causing our rewriting of the loader's RPATH emulation to fail
after running `make install`, as MSYS2 was rewriting our list that looks
like:

```
../bin/libgcc_s_seh-1.dll:../bin/libopenlibm.dll:@../bin/libjulia-internal.dll:@../bin/libjulia-codegen.dll:
```

Into one that looked like:
```
..\bin\libgcc_s_seh-1.dll;..\bin\libopenlibm.dll;@..\bin\libjulia-internal.dll;@..\bin\libjulia-codegen.dll;
```

By exporting `MSYS2_ARG_CONV_EXCL='*'` for all `stringreplace`
invocations, we dodge this issue, as documented by MSYS2 [0].

[0] https://www.msys2.org/wiki/Porting/#filesystem-namespaces

* [win] Disable MSYS2 path munging when calling `is.exe` (#46867)

Tragically, I believe MSYS2 is messing with options such as
`/VERYSILENT` turning them instead into `C:\msys2\VERYSILENT` or
similar.

Co-authored-by: Elliot Saba <staticfloat@gmail.com>
staticfloat added a commit that referenced this pull request Dec 21, 2022
@staticfloat
[win] Disable MSYS2 path munging when calling is.exe (#46867)
e8fef01 
Tragically, I believe MSYS2 is messing with options such as
`/VERYSILENT` turning them instead into `C:\msys2\VERYSILENT` or
similar.
staticfloat added a commit that referenced this pull request Dec 22, 2022
@staticfloat
[win] Disable MSYS2 path munging when calling is.exe (#46867)
0842e61 
Tragically, I believe MSYS2 is messing with options such as
`/VERYSILENT` turning them instead into `C:\msys2\VERYSILENT` or
similar.
staticfloat added a commit that referenced this pull request Dec 23, 2022
@staticfloat
[win] Disable MSYS2 path munging when calling is.exe (#46867)
5e2fbfa 
Tragically, I believe MSYS2 is messing with options such as
`/VERYSILENT` turning them instead into `C:\msys2\VERYSILENT` or
similar.
staticfloat added a commit that referenced this pull request Dec 24, 2022
@staticfloat
[win] Disable MSYS2 path munging when calling is.exe (#46867)
2ad26ab 
Tragically, I believe MSYS2 is messing with options such as
`/VERYSILENT` turning them instead into `C:\msys2\VERYSILENT` or
similar.
KristofferC pushed a commit that referenced this pull request Dec 28, 2022
@staticfloat @KristofferC
[win] Disable MSYS2 path munging when calling is.exe (#46867)
f0b8fe7 
Tragically, I believe MSYS2 is messing with options such as
`/VERYSILENT` turning them instead into `C:\msys2\VERYSILENT` or
similar.
KristofferC pushed a commit that referenced this pull request Oct 10, 2023
@staticfloat @KristofferC
[win] Disable MSYS2 path munging when calling is.exe (#46867)
c82830a 
Tragically, I believe MSYS2 is messing with options such as
`/VERYSILENT` turning them instead into `C:\msys2\VERYSILENT` or
similar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inkydragon inkydragon inkydragon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staticfloat @inkydragon