Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not round-trip uncached inference results through IRCode #47137

Merged
merged 1 commit into from
Oct 15, 2022

Commits on Oct 14, 2022

  1. Add ability to not round-trip uncached inference results through IRCode

    There's generally three reasons inference results end up uncached:
    1. They come from typeinf_ext
    2. We discover some validity limitation (generally due to recursion)
    3. They are used for constant propagation
    
    Currently, we convert all such inference results back to CodeInfo,
    in case they come from 1. However, for inference results of kind 3,
    the only thing we ever do with them is turn them back into IRCode
    for inlining. This round-tripping through IRCode is quite wasteful.
    Stop doing that. This PR is the minimal change to accomplish that
    by marking those inference results that actually need to be converted
    back (for case 1). This probably needs some tweaking for external
    AbstractInterpreters, but let's make sure this works and has the
    right performance first.
    
    This commit just adds the capability, but doesn't turn it on
    by default, since the performance for base didn't quite look
    favorable yet.
    Keno committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    0378012 View commit details
    Browse the repository at this point in the history