[REPL] tests: further improve IJulia IO ordering #47178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
added
test
vtjnash
force-pushed
the
jn/47160.2
branch
4 times, most recently
from
e5aceda
to
c8f33aa
Compare
Continuing from #47160, which seems to have been insufficient to fully resolve this problem on CI.
When writing macros, it is best to keep most of the work in functions, since otherwise it is hard to avoid scoping mistakes, and generates too much code. This made the test (and the REPL) crash if the user ever uses the `mod` function.
|
This should fix the CI stability problems introduced by #46781 / #46474 (@KristofferC) |
|
CI failures were unrelated. Merge now? |
KristofferC
added
backport 1.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from #47160, which seems to have been insufficient to fully resolve this problem on CI, as seen here:
https://buildkite.com/julialang/julia-master/builds/16988#0183d896-bc58-4a78-a838-5473d680db20 (since Condition cannot be used this way, but
Base.Event(true)can be used this way)