Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CircleCI caching: allow ftime to be ceil(ftime_req) in Base.stale_cachefile #47433

Merged
merged 2 commits into from
Nov 4, 2022
Merged

CircleCI caching: allow ftime to be ceil(ftime_req) in Base.stale_cachefile #47433

merged 2 commits into from
Nov 4, 2022

Commits on Nov 3, 2022

  1. CircleCI caching: allow ftime to be ceil(ftime_req) in Base.stale_cac… 

    …hefile

It appears that [caching functionalities](https://circleci.com/docs/caching/) provided by CircleCi, a leading CI/CD provider, can truncate timestamps to full seconds, resulting in re-compilations as below:
```
Rejecting stale cache file /root/.julia/compiled/v1.8/ComponentArrays/cYHSD_3rQji.ji (mtime 1.6673960929277816e9) because file /root/.julia/packages/ComponentArrays/YyD7i/src/ComponentArrays.jl 
```

This PR relaxes the `is_stale` check to be robust against rounding-to-second timestamp mutations.

I can provide a minimal CircleCI configuration file to reproduce if this is helpful.
    @nrontsis @DilumAluthge
    nrontsis authored and DilumAluthge committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    f4e6d4e View commit details
    Browse the repository at this point in the history

  2. Mention PR number as a comment in code

    @nrontsis @DilumAluthge
    nrontsis authored and DilumAluthge committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    db1ec9d View commit details
    Browse the repository at this point in the history