-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REPL: make terminating with a trailing colon display output with 1000 row limit #47520
Conversation
This is a good feature but triage does not like using more semicolons to trigger it. |
This could be done as a REPL setting ala #41435, e.g. to enable the pager. |
I have |
I'll try to not die on the hill of Did triage happen to think of any other trailing etc. chars that could be used? |
I've switched it over to if there's a trailing space. Also, the limit now extends to 1000 rows, for safety if a very large object is displayed accidentally. |
I find this behavior somewhat unintuitive, as I'd expect invisible whitespace characters to not change the output. Can't this setting be more explicit, perhaps something like |
Putting this setting under a menu does seem reasonable, I just prefer the ease of doing it very easily, something like this PR does. If there was an options repl added, it could definitely go in there as a sticky setting too. I just think it should be achievable with some simple instruction on an individual input. |
How do people feel about a trailing colon?
|
51b20c2
to
bf9d8e3
Compare
Marking this for a hopefully brief re-triage for the idea of using a trailing colon. |
bf9d8e3
to
980a407
Compare
else | ||
before = get(Base.active_repl.options.iocontext, :displaysize, nothing) | ||
try | ||
Base.active_repl.options.iocontext[:displaysize] = (1000, displaysize(io)[2]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the 1000 value be configurable somehow? Someone will inevitably ask...
triage still doesn't like this with trailing |
Updated to a single trailing
:
This is a proposal to make terminating input in the repl with
;;
a convenient way todisplay
output without row limit.Sometimes you just want to see the entire object, printed in the nice formatting that
display
provides, without truncating to the terminal window height.When generating this the terminal window was quite short to illustrate the effect.
A single
;
still suppresses output.Double
;;
allowsdisplay
to show all rows (requiring the user to scroll up)