Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure bindings handle write barriers for ty and globalref #47580

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Nov 15, 2022

This has probably been wrong for a long time (since being introduced in 7908246). Just noticed it during routine code reading, so I have no examples of misbehavior from it.

@vtjnash vtjnash added bugfix This change fixes an existing bug backport 1.6 Change should be backported to release-1.6 backport 1.8 Change should be backported to release-1.8 backport 1.9 Change should be backported to release-1.9 labels Nov 15, 2022
This has probably been wrong for a long time (since being introduced in 7908246).
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Nov 16, 2022
Copy link
Member

@d-netto d-netto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vtjnash vtjnash merged commit b369511 into master Nov 16, 2022
@vtjnash vtjnash deleted the jn/binding_wb_roots branch November 16, 2022 21:17
KristofferC pushed a commit that referenced this pull request Nov 17, 2022
This has probably been wrong for a long time (since being introduced in 7908246).

(cherry picked from commit b369511)
KristofferC pushed a commit that referenced this pull request Nov 17, 2022
This has probably been wrong for a long time (since being introduced in 7908246).

(cherry picked from commit b369511)
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Nov 17, 2022
@KristofferC KristofferC mentioned this pull request Dec 14, 2022
26 tasks
KristofferC pushed a commit that referenced this pull request Dec 14, 2022
This has probably been wrong for a long time (since being introduced in 7908246).

(cherry picked from commit b369511)
KristofferC pushed a commit that referenced this pull request Dec 14, 2022
This has probably been wrong for a long time (since being introduced in 7908246).

(cherry picked from commit b369511)
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Dec 16, 2022
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Dec 27, 2022
NHDaly pushed a commit that referenced this pull request May 15, 2023
This has probably been wrong for a long time (since being introduced in 7908246).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.6 Change should be backported to release-1.6 bugfix This change fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants