build: separate stdlib manifests by version #47596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
force-pushed
the
jn/version-stdlib-makefile
branch
from
69a07df to
6ae97a8
Compare
staticfloat
reviewed
Nov 17, 2022
| $(JLL_NAMES) | ||
|
|
||
| STDLIBS_EXT = Pkg Statistics LibCURL Downloads ArgTools Tar NetworkOptions SuiteSparse SparseArrays SHA | ||
|
|
||
| $(foreach module, $(STDLIBS_EXT), $(eval $(call stdlib-external,$(module),$(shell echo $(module) | tr a-z A-Z)))) | ||
|
|
||
| ifneq ($(filter $(STDLIBS),$(STDLIBS_EXT)),) |
staticfloat
approved these changes
Nov 17, 2022
vtjnash
commented
Nov 17, 2022
vtjnash
force-pushed
the
jn/version-stdlib-makefile
branch
from
6ae97a8 to
6b1ccb6
Compare
We install these by version, so it helps a lot if they reflect that in the manifest name. Also some other mild cleanup.
vtjnash
force-pushed
the
jn/version-stdlib-makefile
branch
from
6b1ccb6 to
ada760f
Compare
nalimilan
reviewed
Mar 7, 2023
This was referenced Apr 18, 2024
KristofferC
pushed a commit
that referenced
this pull request
Apr 22, 2024
This reverts part of 67b8ac0 (#47596 (comment)). That change broke `make install` from tarballs due to building docs again, which fails as there's no git repo (and also requires Internet access to download UnicodeData.txt. Fixes #54037.
KristofferC
pushed a commit
that referenced
this pull request
Apr 25, 2024
This reverts part of 67b8ac0 (#47596 (comment)). That change broke `make install` from tarballs due to building docs again, which fails as there's no git repo (and also requires Internet access to download UnicodeData.txt. Fixes #54037. (cherry picked from commit d6dda7c)
KristofferC
pushed a commit
that referenced
this pull request
May 8, 2024
This reverts part of 67b8ac0 (#47596 (comment)). That change broke `make install` from tarballs due to building docs again, which fails as there's no git repo (and also requires Internet access to download UnicodeData.txt. Fixes #54037. (cherry picked from commit d6dda7c)
KristofferC
pushed a commit
that referenced
this pull request
May 25, 2024
This reverts part of 67b8ac0 (#47596 (comment)). That change broke `make install` from tarballs due to building docs again, which fails as there's no git repo (and also requires Internet access to download UnicodeData.txt. Fixes #54037. (cherry picked from commit d6dda7c)
KristofferC
pushed a commit
that referenced
this pull request
May 25, 2024
This reverts part of 67b8ac0 (#47596 (comment)). That change broke `make install` from tarballs due to building docs again, which fails as there's no git repo (and also requires Internet access to download UnicodeData.txt. Fixes #54037. (cherry picked from commit d6dda7c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We install these by version, so it helps a lot if they reflect that in the manifest name.