-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regression in generic_bitcast with Union{} arguments. #47605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Nov 18, 2022
dae5df4
to
5a56384
Compare
Rebased and addressed review comments. |
vtjnash
reviewed
Nov 23, 2022
5a56384
to
64f4471
Compare
vtjnash
approved these changes
Nov 24, 2022
CI failures unrelated; win32 seems broken on master too. |
KristofferC
pushed a commit
that referenced
this pull request
Nov 28, 2022
(cherry picked from commit 726bbd7)
51 tasks
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bugfix
This change fixes an existing bug
compiler:codegen
Generation of LLVM IR and native code
regression
Regression in behavior compared to a previous version
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#47170 introduced a regression with bitcasts of error values (i.e.
::Union{}
), resulting in a failed assertion/segfault:This manifested on PkgEval in the testing of ANOVAapprox.jl (as well as Gtk.jl, and probably others), https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_date/2022-11/15/ANOVAapprox.primary.log, which contains code like:
Compiling this results in essentially:
... where inference thinks that %32 produces a Int64, but during codegen it turns out that
π (%4::Int32, Int64)
producesUnion{}
(as determined byconvert_julia_type
) which then crashesbitcast
as seen above.