Optimize TLS access in generated code on FreeBSD #47891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extends the optimization made for Linux in PR 17178 to FreeBSD. The build and all tests pass locally with this change.
ararslan
added
performance
|
lol of course it failed FreeBSD CI. Looks like the FreeBSD version we're using on CI doesn't have https://reviews.freebsd.org/D31427?id=93334. Should be an easy fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the optimization made for Linux in #17178 to FreeBSD.
In #17178, Yichao said
Here we are, 6.5 years later, and I can confirm that Yichao was right: this builds and passes all tests on FreeBSD.